benini / scid

Other
44 stars 15 forks source link

Allow scid5 databases for using in tactics #186

Closed ukscid closed 1 month ago

ukscid commented 1 month ago

This should fix https://sourceforge.net/p/scid/bugs/239/

benini commented 1 month ago

I believe that just using "::file::Open filename" instead of "sc_base open" should work and avoid a lot of duplicate code. -------- Messaggio originale --------Da: ukscid @.> Data: 11/10/24 21:48 (GMT+01:00) A: benini/scid @.> Cc: Subscribed @.***> Oggetto: [benini/scid] Allow scid5 databases for using in tactics (PR #186) This should fix https://sourceforge.net/p/scid/bugs/239/

You can view, comment on, or merge this pull request online at:   https://github.com/benini/scid/pull/186

Commit Summary

6107aa2 Allow scid5 databases for using in tactics

File Changes (1 file)

M
tcl/tools/tactics.tcl
(23)

Patch Links:

https://github.com/benini/scid/pull/186.patch https://github.com/benini/scid/pull/186.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

ukscid commented 1 month ago

::file::open : open the database and load a game ::file::open : open the database and store it in recent list I think both behaviors are not intended when called from tactics. Should ::file::open[] changed to can be used from tactics? Disable this both behaviors when called from tactics via a parameter?

benini commented 1 month ago

Had just a quick look at the code, so I may be wrong. I believe that:

ukscid commented 1 month ago

The straightforward OpenOrSwitch function is not suitable for the use of configBases because the database is then also switched to foreground. However, this is not desired when reading the possible databases. I have therefore added a further function OpenForTest (the name should still be adapted). Maybe there is a better idea how to solve this. I have taken the other improvements from your branch.