benini
commented
1 year ago Uwe, I don't understand. I keep asking you to create small pull requests, and you keep creating ones with hundres of changed lines. There are many guidelines on the internet, let's just pick stockfish's one: https://github.com/glinscott/fishtest/wiki/Creating-my-first-test In particular points #2 and #4.
I don't think you appreciate how this will help you too. Just the first line is so wrong:
- parent: there is a specific meaning for the word parent in computer science and in particular in the tk framework. That's not a parent, that is a misleading variable name.
- .main.board: that's a global variable. There is infinite literature that's explain why they should be avoided. Let's just point out that now to change the .main.board name you would have to test everything that use ::board::popup too.
But if you made a pull request just for that: "add a flip parameter to ::board::popup". It would be clear that you just wanted to add a {flip false} parameter.
The same applies to the single line change in ::board::material. When you try to describe what you are doing, you'll notice that you are changing a dynamic fen, which is updated when the function is called, with a static fen which is changed who knows when. That's huge. There is now an implicit requirement that $::board::_data is always updated before ::board::popup is invoked. It not only takes a lot of time to test that, but what about future changes? How should one know/remember this implicit requirement? But if you made a pull request just for that: "Let ::board::material accept the FEN as a parameter", it would be clear that all the above pain is not necessary.
first version of modified gamebrowser. s. feature request https://sourceforge.net/p/scid/feature-requests/88/ new functions: show comments, show variants, enable/disable this show evalbar, materialbar, enable/disable this 2 buttons for resize board (workaround for keys) show popupboard on right mouse click this includes the ability to flip the popupboard like the browser board and a function for convert FEN to board ( this should be better implemented in cpp)