search

benirose / O_C-BenisphereSuite

Benisphere Suite is a continuation of Hemisphere Suite, an alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.
168 stars 17 forks source link

DrumMap: Save all parameters but decrease manual resolution #10

Closed qiemem closed 2 years ago

qiemem commented 2 years ago

Follow-up to #6, if you'd like it.

This saves all parameters of DrumMap, but at the cost of slightly reducing the manually adjusted granularity of each. CVing the parameters still has full 8 bit resolution, as does the randomness introduced by chaos.

Fill parameters are given 5 bits each, x and y 6 bits, and chaos 4 bits. See #6 for details. As I mention there, I haven't found the decreased resolution to be particularly noticeable in practice, but again, completely understand if you don't want to include this.

Given the decrease in number of values for each parameter, knob acceleration no longer felt necessary, so I removed it as well (as much as I liked that feature).

Also, happy to toss the packmacros thing if that seems unnecessary to you. Makes messing with storage representation safer and easier, but is silly macro trickery.

benirose commented 2 years ago

Thanks for all your help @qiemem! As we discussed outside of this PR, I am working on getting 64-bit save data support in applets, and I nearly have it ready! Since this will allow me to save all of the parameters, I'm going to close this PR.