Allow applets to save 64-bits of data

benirose / O_C-BenisphereSuite

Benisphere Suite is a continuation of Hemisphere Suite, an alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.

168 stars 17 forks source link

Allow applets to save 64-bits of data #16

Closed benirose closed 2 years ago

benirose commented 2 years ago

This will allow applets with a larger amount of parameters to still be able to save them all without having to reduce precision on save/load.

benirose commented 2 years ago

Still remaining todo:

[x] Update Sysex methods to use 64 bits
[ ] Scan other applets that could use the extra space and update their save/load methods
[x] ~See if I can refactor from STORAGE_TYPE_U16 to STORAGE_TYPE_U32~

benirose commented 2 years ago

I am fairly certain that the changes to sysex will hold up with previous dumps that only have 32-bits of data, but I wouldn't mind a second set of eyes (the code where it's packed and unpacked are in HSMIDI.h)

benirose commented 2 years ago

Alright, I'm tired of this sitting and holding up other PRs, I'm going to move forward with this and address any issues that come up in beta testing.