search

benirose / O_C-BenisphereSuite

Benisphere Suite is a continuation of Hemisphere Suite, an alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.
168 stars 17 forks source link

Stairs/stepper don't run in the flipped version of the firmware #22

Open glibglobber opened 2 years ago

glibglobber commented 2 years ago

I switched over to unflipped and they run just fine, though.

benirose commented 1 year ago

Is this still an issue in the latest release?

spacelordmother commented 1 year ago

I'm still having this issue on version 1.3.1. Also with apps Carpeggio and Shredder. My issue only occurs when I try to run these apps on the right hemisphere.

djphazer commented 1 year ago

After some testing, I believe the root of this issue is that calibration data is improperly applied to the CV inputs in the flipped firmware. All 4 inputs on my module end up with a slight offset, which would cause some applets to appear unresponsive. Still not quite sure of the simplest proper solution tho...

djphazer commented 1 year ago

Fix - https://github.com/djphazer/O_C-BenisphereSuite/commit/0bd6a6f82e3f0137df40c0796547019acae4d8fc

Not as elegant as I hoped, but it works. A better approach might be to reverse the arrays of calibration data on load (and save)