search

benirose / O_C-BenisphereSuite

Benisphere Suite is a continuation of Hemisphere Suite, an alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.
168 stars 17 forks source link

Fix loading saved applet data #41

Closed djphazer closed 1 year ago

djphazer commented 1 year ago

I was getting unexpected results when storing/reloading some applet data (I noticed it in ShiftReg) This seems to have corrected it - More explicit data casts, and bitwise OR rather than addition.

benirose commented 1 year ago

I'm not sure why I was being lazy in that initial change in 1.2, and I agree the ORs are better than the plusses, even if that's how it was before. Thanks for the contribution!

benirose commented 1 year ago

Oh actually I just realized the shiftreg issue is fixed in a different commit where I change the order of params saved, but now that I think about it this was probably the root cause, so I'm glad to have it in regardless and I don't have to wonder why I had to change the order of saved params!