search

benirose / O_C-BenisphereSuite

Benisphere Suite is a continuation of Hemisphere Suite, an alternate firmware for Ornament and Crime, featuring a dual-applet framework with dozens of different modular functions.
168 stars 17 forks source link

Add OC_strings to DualQuant in case enigma app is disabled. Fix #38 #56

Closed Nagasaki45 closed 1 year ago

Nagasaki45 commented 1 year ago

As mentioned on #38, disabling the enigma app causes a compilation error because DualQuant is missing the #include "OC_strings.h".

djphazer commented 1 year ago

Seems like a more general solution would be to put it in o_c_REV.ino as suggested in #38 - this is fairly trivial tho. Whatever works!

Nagasaki45 commented 1 year ago

Hi @djphazer. Thank you for the comment. I've updated the PR to include OC_strings.h in o_c_REV.ino and remove it from everywhere else. Not very familiar with arduino / C so hope that what you want.

benirose commented 1 year ago

I'm gonna finally merge this! "What's the worst that could happen" - @djphazer 🤣