MIDI In doesn't handle overlapping notes

[khogeland]

Hi, I'm trying to hook up a MIDI keyboard, but it's not really playable because the MIDI In app doesn't handle overlapping keys well:

• The gate signal is always cleared when a note off message is observed, it should only be cleared once all keys have been released (once the number of note off messages equals the number of note on messages). Even a few milliseconds of overlap while switching from one note to the next clears the gate, so this really prevents using a keyboard at all.
• The note signal is always the most recent note observed, intuitively it should always output the most recently pressed key that is still being held

I haven't thought about how velocity or the other signals should behave, I only tried these two

[djphazer]

I just made a tweak in my fork so that Gate only turns off when Note Off matches the most recent Note On. This feels a little better to me, but I'll try to improve on it more when I can.

To do it properly will require some work to keep track of multiple notes. I plan on eventually giving the whole MIDI system an overhaul!