beniwtv / vr-streaming-overlay

SteamVR overlay for streamers on Linux/Windows
MIT License
33 stars 2 forks source link

[WIP] Initial work on Odysee Chat widget #17

Open tuxfoo opened 3 years ago

tuxfoo commented 3 years ago

I am creating an overlay for Odysee livestreaming.

Thought I would create the initial PR. Feedback is welcome.

It can be seen in action here: https://odysee.com/@tuxfoo:e/livestreamhighlights:5

beniwtv commented 3 years ago

Very cool!

So far looks good! :)

The only thing that I would have Feedback on is the claim_id. That should be moved to a connector, so it gets configured in the connections tab and is encrypted in the user's save file.

Eventually, connectors will become more powerful and widgets may be able to use more than one connection (think, for example, a combined chat widget for multiple streaming sites).

tuxfoo commented 3 years ago

thanks, I might do that once the superchat is implemented but for now I leave in widget settings as claim_id's are public, so it does not need to be encrypted.

Very cool!

So far looks good! :)

The only thing that I would have Feedback on is the claim_id. That should be moved to a connector, so it gets configured in the connections tab and is encrypted in the user's save file.

Eventually, connectors will become more powerful and widgets may be able to use more than one connection (think, for example, a combined chat widget for multiple streaming sites).

beniwtv commented 3 years ago

Still that would make it easier to make the combined chat widget, even if it doesn't technically need encryption :)

Plan is to move all the "communication" to the connectors - so widgets have a standard interface for different services.

tuxfoo commented 3 years ago

Made it work with a connector as well as some other changes. https://github.com/tuxfoo/vr-streaming-overlay/commit/61230c0de55dd262e6aa6660ebbd59b2d2b26bac

I just need to test it.

beniwtv commented 3 years ago

Sweet! Wiill also check it if I get some time (hopefully this week)

tuxfoo commented 3 years ago

Do you have a Odysee Channel? Need 50LBC on channel to live stream at the moment.

Let me know if you create a channel, I can spare 50 LBC so that you can live stream. Of course, you can also test it using some one elses live stream.

HadetTheUndying commented 3 years ago

I can test this later next week.

tuxfoo commented 3 years ago

Cool, let me know how it goes.