search

benjaffe / chrome-okc-plugin

OkCupid Poly Plugin
MIT License
63 stars 32 forks source link

Plugin is too big #122

Open benjaffe opened 9 years ago

benjaffe commented 9 years ago

The plugin should only package the minified libraries, not everything in bower_components.

AstraLuma commented 9 years ago

Define "too big"? Do you have a goal in mind?

Given that this is installed and not served, what benefit do you expect to derive?

benjaffe commented 9 years ago

It's not a big benefit, but with 11k users, it's not irrelevant, especially if updates are ever more frequent than they currently are.

Also, a minor point... it'd take less time to upload new versions (it currently takes 10-20 seconds)

If we use the build script to package the plugin better, and it only uses the files we need (especially from bower_components and lib), the uncompressed file size would go from ~18.5 MB to ~ 0.4 MB.

I don't have a goal on when to implement this, but it's easily worth it if the gain is greater than an order of magnitude!

AstraLuma commented 9 years ago

Uhh, yeah. Size reduction of 4600% is totally worth it.