search

benjaffe / chrome-okc-plugin

OkCupid Poly Plugin
MIT License
62 stars 32 forks source link

Some general styling tweaks #133

Open michaelpelletier opened 9 years ago

michaelpelletier commented 9 years ago

Changes:

screen shot 2015-07-18 at 8 24 00 am
benjaffe commented 9 years ago

Wow! I am super excited about this.

I'm on vacation for the next month with no computer, so even if I merged, I couldn't ship it. That said, I know what I'll be doing as soon as I get back!

Awesome work. I'll review it more thoroughly in late August when I get home.

On Sat, Jul 18, 2015, 21:25 Michael Pelletier notifications@github.com wrote:

Changes:

  • Fix some links not having cursor pointers.
  • Remove unused table structure.
  • Fix user bio (username/age/location) blocked profile image preview.
  • Fix modal gets slightly covered by header.
  • "Redesign" Change Categories section.
  • Some misc styling tweaks.

[image: screen shot 2015-07-18 at 8 24 00 am]

https://cloud.githubusercontent.com/assets/1640601/8761578/74dd38ae-2d26-11e5-861a-f44f6f3d8312.png

You can view, comment on, or merge this pull request online at:

https://github.com/benjaffe/chrome-okc-plugin/pull/133 Commit Summary

  • Make Plugin Menu / Label buttons have pointer cursor.
  • Don't use a table because there is no actual reason to.
  • Tweak display of Category selection.
  • Fix modal appearance because the okc header is larger now.
  • Fix user name and details can block profile image previews.
  • Labels and Plugin Menu menu cleanup.
  • Misc styling tweaks.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/benjaffe/chrome-okc-plugin/pull/133.

michaelpelletier commented 9 years ago

No rush! I want to do more with it, too, but I figured this was a good starting place.

I also have a second (completely unrelated) PR for adding some nerdy category options for things that I care about (well-read, interest in programming, things like that) which I was going to open as well but I foolishly did this one on Master so it includes these changes, too. So I'll hold on that one for now.

But there's a good chance that I'll add more to this during your vacation!

benjaffe commented 9 years ago

It makes me super happy to know that this project is still moving during my development-free month. :D

On Tue, Jul 21, 2015, 06:45 Michael Pelletier notifications@github.com wrote:

No rush! I want to do more with it, too, but I figured this was a good starting place.

I also have a second (completely unrelated) PR for adding some nerdy category options for things that I care about (well-read, interest in programming, things like that) which I was going to open as well but I foolishly did this one on Master so it includes these changes, too. So I'll hold on that one for now.

But there's a good chance that I'll add more to this during your vacation!

— Reply to this email directly or view it on GitHub https://github.com/benjaffe/chrome-okc-plugin/pull/133#issuecomment-123053682 .