benjaffe / chrome-okc-plugin

OkCupid Poly Plugin
MIT License
63 stars 32 forks source link

Proposed additions and renaming of category: pet_friendly #153

Open stn4d89 opened 8 years ago

stn4d89 commented 8 years ago

Consider renaming to animal-friendly and lump in animal rights, vegan, furr, etc. Or, add a supercategory and include the pet items in it.

"pet_friendly" {"qid":"94667","text":" Do you like cats? ","answerText":["Yes","No","Yes, but I'd rather not live with one.","I don't really care."],"score":[1,0,1,0],"weight":[1,1,1,1]} {"qid":"1588","text":" Do you like cats? Would you consider owning a cat as a pet? ","answerText":["Yes, I would love (or do own) a cat.","I'm not too into them, but I wouldn't mind one.","No, I dislike cats.","I like them, but I'm allergic."],"score":[1,1,1,1],"weight":[1,1,-1,1]} {"qid":"35778","text":" Would you allow a pet to sleep on your bed? ","answerText":["Yes.","No.","Maybe."],"score":[1,-1,0],"weight":[1,1,1]}

Animals more generally: animal_friendly {"qid":"12428","text":" Would you risk your life to save a dying animal? ","answerText":["Yes","No"],"score":[1,-1],"weight":[1,.5]} {"qid":"17991","text":" Would you risk your life for an animal? ","answerText":["Yes","No"],"score":[1,-1],"weight":[1,.5]} {"qid":"32807","text":" Do you condone the wearing of fur for fashion? ","answerText":["Yes, why not?","No, those poor animals!","Sort of; faux fur only!","No opinion or don't know/care."],"score":[-1,1,-1,0],"weight":[1,1,.5,1]} //if renamed animal-friendly and lump in animal rights, vegan, furr, etc? {"qid":"28685","text":" Do you believe that humans are the most important animal species on Earth? ","answerText":["Yes","No","I'm not sure"],"score":[-1,1,0],"weight":[1,1,1]}

benh57 commented 8 years ago

I have the release installed and i don't see a pet friendly category at all. Was thinking of adding it. Where are you seeing it?

shellysp commented 8 years ago

Hmmmm... it appears to be in to_integrate.js. That file, in my checkout, is timestamped the min of my checkout, so I don't think it's something that I added.

    "pet_friendly": [
        {
            "qid": "1212",
            "text": "Do you like dogs?  Would you consider owning a dog as a pet?",
            "answerText": ["Yes, I would love (or do own) a dog.", "I'm not too into them, but I wouldn't mind one.", "No, I dislike dogs.", "I like them, but I'm allergic."],
            "score": [0, 0, 0, 0],
            "weight": [0, 0, 0, 0]
        }
    ],
benh57 commented 8 years ago

Aha, there it is. Looks like those categories only show up in devmode.

if (_OKCP.devmode) {

Well, perhaps i will try integrating the questions into a full category and submitting a PR.

shellysp commented 8 years ago

BTW, did you integrate any of my other suggested q's/cats?

benjaffe commented 8 years ago

Sorry, I haven't had time to work on this project much lately. It's on my radar though for whenever I have time to integrate new questions.

Wyrdbyrd commented 8 years ago

Please add allowances for dander allergies and animal phobias, please. I approve of dander-bearing animals from a distance, but the fuzzy cuties make breathing difficult for some of us.

Batshua commented 4 years ago

Seconding a request to screen for specific pets. I am allergic to cats, dogs, and rabbits and despite MULTIPLE attempts to request devs @ OKC put in at least simple filtering for cats and dogs (since there's already fields for that), I keep getting matched with cat and dog owners.