search

benjaffe / chrome-okc-plugin

OkCupid Poly Plugin
MIT License
63 stars 32 forks source link

Fix for recent OKC changes. Fixes #161. #162

Closed tfmorris closed 8 years ago

tfmorris commented 8 years ago

This has only been lightly tested and I haven't made any attempt to preserve backward compatibility, which may be necessary if this is a rolling update like they often do, but it does seem to fix the main problems.

benjaffe commented 8 years ago

Fantastic!! I'll test this out tonight and release if all is well.

benjaffe commented 8 years ago

Releasing it! Thank you Tom!

tfmorris commented 8 years ago

Hi Ben. Did you test the onOwnProfile leg of things? I wasn't sure how that worked, so wasn't able to test it. If you did test it and it's OK, you can remove the obsolete TODO.

I also wasn't sure if this change had been rolled out globally by OKCupid. I'm assuming that the lack of any backward compatibility code means that it has, correct?

benjaffe commented 8 years ago

To be honest, I don't remember how that worked UI-wise! I think it may have been more relevant on a previous version of the site, so that's just legacy code.

What should really happen is the plugin should be largely rewritten. I don't foresee myself having enough time to do it.

Thank you for your work on this! And by the way, If this is a project you're interested in working on, I will gladly test out and release changes you make.