search

benjajaja / ratatui-image

Ratatui widget for rendering image graphics in terminals that support it
https://crates.io/crates/ratatui-image
MIT License
96 stars 14 forks source link

Image preview in joshuto is off #21

Closed BigBrotherJu closed 5 months ago

BigBrotherJu commented 5 months ago
image

This is 0.9.8 joshuto and 0.33.1 kitty. There is a black bar at the bottom of the image.

BigBrotherJu commented 5 months ago

@benjajaja

benjajaja commented 5 months ago

Due to ratatui's immediate-mode nature, the cells behind the image must be "skipped" so that nothing draws over the image. In other words, the cells behind the image still have whatever was drawn last time before they were marked skipped for the image. Thus, the image must always fill the cells/area, and the frame cannot be made transparent.

I will make a PR to configure the background color, though.

benjajaja commented 5 months ago

https://github.com/kamiyaa/joshuto/issues/521