Generates invalid config for `engine_version`

benjamimgois / goverlay

GOverlay is an opensource project that aims to create a Graphical UI to help manage Linux overlays.

GNU General Public License v3.0

633 stars 40 forks source link

Generates invalid config for `engine_version` #123

Closed pallaswept closed 3 months ago

pallaswept commented 4 months ago

GOverlay 1.1.1 stores the engine_version option with the invalid name engine. This generates an error:

> mangohud vkcube  
[2024-07-01 13:49:29.185] [MANGOHUD] [error] [overlay_params.cpp:647] Unknown option 'engine'

I don't know this codebase well, but a simple replacement of this string in a few places seems like it should sort it out. I'd be happy to file a PR if that would help?

benjamimgois commented 4 months ago

Thanks for reporting @pallaswept , will fix it on upstream.

benjamimgois commented 3 months ago

fixed in 1.2 release

pallaswept commented 3 months ago

Thanks very much! Wow, congrats on that release, that's a huge one!!