Misc bug fixes (commenting-on-posts)

mayankshouche commented 3 years ago

~~1. collapsible comment box (see reddit desktop) (@mayankshouche)~~

~~2. infinite loop of requests to /resource/... on resource pages, has to do with the useEffect

The 'fetchResource' function makes the dependencies of useEffect Hook (at line 73) change on every render. To fix this, wrap the 'fetchResource' definition into its own useCallback() Hook~~

~~3. make replies reload page state so they show up (@stephen8chang)

right now, once submitting a reply/comment page does not repaint with the new comment
some replies not rendering even though comment count correct~~

~~4. make comment/ api routes send back a 200 when successful (@rafaykhurram)~~

~~5. error checking for /comment/.* api responses (@rafaykhurram)

api response could fail - make sure to display error on frontend if this happens~~

~~6. firewall access denied errors in server output (@normanwang1234)

~~

benjamin-fa commented 3 years ago

In response to the third bug on loading replies, it took about a minute and 15 seconds for all the comments to load on the "Scale 3D Sensor Fusion, Scale Image, Scale Video, Scale Text, and Scale Document API" resource for me. They rendered in waves (first 8, then 13 and finally 29 comments). Also, there are 29 total comments/replies but the page numerically says there are 12 replies.

stephen8chang commented 3 years ago

Bug number 3 on this issue is fixed

rafaykhurram commented 3 years ago

Bugs #4 and #5 on this issue are fixed.

mayankshouche commented 3 years ago

Opened PR for issue 1 since it could be a breaking change: #30

mayankshouche commented 3 years ago

Bug 6 fixed through other changes

benjamin-fa / ai-portal

Misc bug fixes (commenting-on-posts) #28