search

benjamin-hodgson / Pidgin

A lightweight and fast parsing library for C#.
https://www.benjamin.pizza/Pidgin/
MIT License
879 stars 68 forks source link

Make `CurrentOffset` long type? #161

Closed wakuflair closed 1 month ago

wakuflair commented 2 months ago

https://github.com/benjamin-hodgson/Pidgin/blob/08fde6d183dccf4d0b326ef8e5ba4076d5a57593/Pidgin/Parser.CurrentOffset.cs#L8

Hi @benjamin-hodgson I'd like to use a long type CurrentOffset, as for large binary data, int may not be enough.

benjamin-hodgson commented 2 months ago

Great point, I obviously wasn't thinking and just defaulted to int. I'll have to make it a new API (ie CurrentOffsetLong or similar) so as not to break existing usages - any input on the naming?

benjamin-hodgson commented 1 month ago

Shipped in 3.3.0 https://www.nuget.org/packages/Pidgin/3.3.0