benjamin-hodgson / asynqp

An AMQP library for asyncio
MIT License
84 stars 29 forks source link

Await is reserved keyword in python3.7 #103

Closed macdewee closed 6 years ago

macdewee commented 6 years ago

As await is reserved in python 3.7, I propose to change name of function await to e.g. _await:

lib/python3.7/site-packages/asynqp/connection.py", line 84
    yield from self.synchroniser.await(spec.ConnectionCloseOK)
                                     ^
SyntaxError: invalid syntax
benjamin-hodgson commented 6 years ago

Or just wait. It's an internal function so should be safe to rename. I'd accept a PR

JustinTArthur commented 6 years ago

I think this can be closed out. Was addressed in pull #104.