benjamin-hodgson / asynqp

An AMQP library for asyncio
MIT License
84 stars 29 forks source link

Pass custom attribute tables #27

Closed fwiesel closed 9 years ago

fwiesel commented 9 years ago

The argument tables can be used for various extensions on rabbitmq.

As described in #26, due to some incompatibilities, it only works with a change to the serialiser code table (or a restriction to a subset).

The pull request includes 9c826d1from pull request #26, but that change could be replaced with an alternative implementation of serialiser.

benjamin-hodgson commented 9 years ago

Thanks for the contribution. I've made a few comments in the diff. Am I right in thinking that this addresses issue #2?

fwiesel commented 9 years ago

Yes, the functionality requested in #2 should be available with those changes.

benjamin-hodgson commented 9 years ago

@fwiesel GitHub's telling me there are merge conflicts. Please could you rebase your branch onto the latest master and force-push it?

fwiesel commented 9 years ago

Sure. Sorry, that I missed that.