Closed TarasLevelUp closed 9 years ago
Will add some tests to fix up coverage on weekend. Wanted to get feedback on code changes as soon as possible, so didn't look that deep on coverage, sorry.
Upon a skim-read this code looks good, but the wide scope of this pull request makes it hard to review. Do you think you could split up your changes into logical units and submit them as separate patches? For example, one PR for the QueueReader
optimisation, another for the flow control stuff, etc. This will make it easier for me to review and will simplify the commit history.
Yes, I can. Will do on weekend then
Oh that's great, thanks. Looking forward to it!
What was the purpose of such a refactor:
async
tasks from QueueReader and ChannelActor so we don't need to use _TEST hack and for speed reasons #44 .In the process I saw some places, that could be optimised:
drain()
from transport writes. I use it on close, so we inform server before closing connection (sending CloseOK may not be enough if buffers are full.)Feel free to comment on things, you consider needs changing. I think the way I pass ConnectionClose to be dispatched to all Writers is a bit ugly and Synchroniser's way to save future for more than 1 method can be written more cleanly.