benjamin-hodgson / asynqp

An AMQP library for asyncio
MIT License
84 stars 29 forks source link

Refactored reader to not use async calls #48

Closed TarasLevelUp closed 9 years ago

TarasLevelUp commented 9 years ago

Fixes #44

benjamin-hodgson commented 9 years ago

Looking good! I've made a suggestion for a minor refactoring in the diff but after that's addressed I think this is good to go :sunglasses:

tvoinarovskyi commented 9 years ago

I didn't want to rename Reader, as it really suits the reader.ready call. It's very intuitive. As for the QueueReader part renamed it to QueuedReader along with some other parts to be more descriptive of new behaviour