search

benjamin-hodgson / asynqp

An AMQP library for asyncio
MIT License
84 stars 29 forks source link

Added server side consumer cancel #60

Closed tvoinarovskyi closed 8 years ago

tvoinarovskyi commented 8 years ago

https://www.rabbitmq.com/consumer-cancel.html

benjamin-hodgson commented 8 years ago

This is good. The one thing I think we should do is check whether the server supports consumer_cancel_notify at startup

tvoinarovskyi commented 8 years ago

I don't really understand what to do if it doesn't. It's not a problem to us I think.

tvoinarovskyi commented 8 years ago

Or you want something like: connection.capabilities?

tvoinarovskyi commented 8 years ago

Rebases. What about the connection.capabilities question? Did you expect something like that?

benjamin-hodgson commented 8 years ago

No, I think you're right. A server which doesn't support consumer_cancel_notify won't be sending us cancel requests, so there's no need. It'll just be dead code. We might want to expose connection.capabilities for querying by clients but I don't think there's any pressing need for it

tvoinarovskyi commented 8 years ago

Rebased. This should be OK to merge.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.1%) to 95.944% when pulling 036e10711a279c213fdc306e6923dddc0932559b on TarasLevelUp:server_side_consumer_cancel into 8f55f2f03cba8aea7c8f1532fa283df3bc50b02e on benjamin-hodgson:master.

tvoinarovskyi commented 8 years ago

rebased