benjamin-hodgson / asynqp

An AMQP library for asyncio
MIT License
84 stars 29 forks source link

Added QueuedConsumer implementation #65

Open tvoinarovskyi opened 8 years ago

tvoinarovskyi commented 8 years ago

With Python3.5 support for async with and async for.

NOTE: There are no tests for it. Can't wrap my head around how to implement a separate test for python35, any suggestions?

TarasLevelUp commented 8 years ago

I think this is a little too much to even view at a time. I will split up the Python3.5 and only create a PR for Python3.4 (with tests) later.

benjamin-hodgson commented 8 years ago

Regarding testing 3.5-specific functionality - you should be able to just make a test which runs only in 3.5.

if PY35:
    class WhenTestingPython35SpecificFunctionality:
        ...