benjamin-hodgson / asynqp

An AMQP library for asyncio
MIT License
84 stars 29 forks source link

Remove QueuedReader and fix method cancellation #70

Open tvoinarovskyi opened 8 years ago

tvoinarovskyi commented 8 years ago

As I stated in #52 fixing the cancellation issue without removing reader is too hard. I've gone through the code base. The Reader is responsible for synchronous consumption of frames, but there is No need for that if we just maintain the code correctly:

In asyncio we already have the loop, which has a great scheduling machinery, that will guaranty sequential call order.

tvoinarovskyi commented 8 years ago

If it's hard to review for 0.5 we can just set it to be fixed in 0.6.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 96.009% when pulling bc4265f69f936ff8767fcc7079150bce1a2d122f on TarasLevelUp:cancel_methods into 8f55f2f03cba8aea7c8f1532fa283df3bc50b02e on benjamin-hodgson:master.