search

benjamin84 / fest

Automatically exported from code.google.com/p/fest
0 stars 0 forks source link

Reducing the speed doesn't work anymore #127

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. application.= new FrameFixture(robot, getApplication.());
   application.robot.settings().delayBetweenEvents(5);

What is the expected output? What do you see instead?
The delays should be shorter, but the execution doesn't get any faster.

What version of the product are you using? On what operating system?
fest-swing 1.0a

Original issue reported on code.google.com by manuel.k...@gmail.com on 10 Apr 2008 at 12:34

GoogleCodeExporter commented 9 years ago 
We'll investigate this issue. Thanks a lot Manuel :)

Original comment by Alex.Rui...@gmail.com on 10 Apr 2008 at 1:52

GoogleCodeExporter commented 9 years ago 
I figured out the cause of the long wait times between events Manuel and I were
experiencing. 

We just reduced the time of delayBetweenEvents, but didn't reduce the time of
eventPostingDelay. After reducing eventPostingDelay execution gets faster 
again. I
don't know if it is actually a bug, but maybe there should be a comment or hint 
in
the javadoc, that these two times are connected.

But the behavior in RobotFixture is also confusing probably wrong, in the method
waitIfNecessary there is the following code:

if (eventPostingDelay > delayBetweenEvents) pause(eventPostingDelay -
delayBetweenEvents);

When we created this bug, we had delayBetweenEvents set to 5 ms (we know, this 
is
really short) and and eventPostingDelay set to its default value of 100 ms.

If I read the above code I figure out, we actually had a pause of 95 ms between 
each
event. Now, if I would set delayBetweenEvents to 50 ms we would have a pause of 
only
50 ms between events? And even worse, if I set delayBetweenEvents to 99 ms we 
would
have a pause of only 1 ms between events. Maybe I also missed a point somewhere.

Original comment by matthi...@gmail.com on 2 May 2008 at 8:25

GoogleCodeExporter commented 9 years ago 
Many thanks for the update! :)

Having these two delays is definitely confusing. I will review the code. My 
goal is
to consolidate these two delays into one (if possible), or at least document the
relationship between them.

Original comment by Alex.Rui...@gmail.com on 2 May 2008 at 1:42

GoogleCodeExporter commented 9 years ago 
For this release (1.0a2) we are going to update the Javadocs without changing 
code.
We need to carefully decide if we are going to unify these two delay values. We
definitely will have it fixed (one way or another) in 1.0a3. We have many new
features/bug fixes that need to be released. We apologize if this creates any
inconvenience :(

Please let us know what you think. We plan to release some time this week (may 
be
this Friday, or Monday next week the latest).

We truly appreciate your help! :)

Original comment by Alex.Rui...@gmail.com on 14 May 2008 at 4:53

GoogleCodeExporter commented 9 years ago 
Manuel & Mattias,

I was thinking changing the status of this bug from 'defect' to 'enhancement', 
since
you found how to speed up tests (many, many thanks!). I was also thinking about
addressing this issue in version 1.1, what do you think?

Many thanks!
-Alex

Original comment by Alex.Rui...@gmail.com on 15 Jul 2008 at 11:59

GoogleCodeExporter commented 9 years ago 
Changing the status to enhancement would be ok I think, as it wasn't really a 
bug - 
we found out how it works, it was just difficult to find out.

Original comment by matthi...@gmail.com on 16 Jul 2008 at 7:02

GoogleCodeExporter commented 9 years ago 
Thanks Matthias :)

Original comment by Alex.Rui...@gmail.com on 16 Jul 2008 at 2:28

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Issue migrated to http://kenai.com/jira/browse/FEST-24

Original comment by Alex.Rui...@gmail.com on 15 Feb 2009 at 3:29

GoogleCodeExporter commented 9 years ago 
Issue migrated to http://jira.codehaus.org/browse/FEST-25

Original comment by Alex.Rui...@gmail.com on 2 Mar 2009 at 8:10