NullPointerException from JTextComponentDriver#deleteText

[GoogleCodeExporter]

I'm using version 1.0a1 of the FEST-Swing module.

  public void deleteText(JTextComponent textBox) {
    replaceText(textBox, null);
  }

The problem is that JTextComponentDriver#deleteText calls #replaceText with
null.

  public void replaceText(JTextComponent textBox, String text) {
    selectAll(textBox);
    if (isEmpty(text) && !isEmpty(textBox.getText())) {
        invokeAction(textBox, deletePrevCharAction);
        return;
    }
    enterText(textBox, text);
  }

In JTextComponentDriver#replaceText if the text is null (implicitly empty)
and the text box is also empty then the body of the if isn't executed,
i.e., the return isn't executed, so #enterText is called with null text.
Further down the call stack #enterText calls RobotFixture#enterText

  public void enterText(String text) {
    for (char character : text.toCharArray())
      type(character);
  }

RobotFixture#enterText tries to call toCharArray() on text, without
checking it for null.

A possible solution is:

  public void replaceText(JTextComponent textBox, String text) {
    selectAll(textBox);
    if (isEmpty(text)) {
      if (!isEmpty(textBox.getText())) {
        invokeAction(textBox, deletePrevCharAction);
      }
      return;
    }
    enterText(textBox, text);
  }

Another solution would be to modify JTextComponentDriver#deleteText to call
#replaceText with "" instead of null, but null seems to be acceptable as
JTextComponent#setText also accepts null and Robot#enterText shouldn't
concern itself with null, it should assume that it's called with "real"
text to enter.

Original issue reported on code.google.com by csaba.ju...@gmail.com on 10 Jun 2008 at 2:52

[GoogleCodeExporter]

Original comment by Alex.Rui...@gmail.com on 10 Jun 2008 at 8:58

• Changed title: [fest-swing] NullPointerException from JTextComponentDriver#deleteText
• Changed state: Accepted
• Added labels: Milestone-Release1.0, OpSys-All, Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Hi Csabi,

This was already fixed in version 1.0a2 ( issue 123 )

Thanks!
-Alex

Original comment by Alex.Rui...@gmail.com on 12 Jun 2008 at 3:00

• Changed state: Duplicate

[GoogleCodeExporter]

Set the module as a label, instead of being part of the title.

Original comment by Alex.Rui...@gmail.com on 1 Dec 2008 at 2:02

• Changed title: NullPointerException from JTextComponentDriver#deleteText
• Added labels: Module-fest-swing