search

benjaminRomano / todo-manager

Manage TODOs, NOTEs, etc. from inside Atom.
https://atom.io/packages/todo-manager
MIT License
4 stars 2 forks source link

Include list filter #16

Open aurovrata opened 6 years ago

aurovrata commented 6 years ago

I'd like to ignore a general folder,

**/wp-content/**

but retain a sub-folder,

**/wp-content/themes/**

benjaminRomano commented 6 years ago

I haven't looked at this code in a very long time, but I believe we are using minimatch and that library has syntax to support this use case.

Here is the docs for minimatch: https://github.com/isaacs/minimatch

Ingoring logic happens here: https://github.com/benjaminRomano/todo-manager/blob/master/lib/regexMatcherUtil.coffee#L100

aurovrata commented 6 years ago

thanks, apparently minimatch should be able to accept -ve patterns, I tried

**/wp-content(?!\/themes\/)/**

but it doesn't work

benjaminRomano commented 6 years ago

The version of minimatch in this package is 2.0.10 which is now 3 years old. It's very possible that this functionality doesn't exist in this version.

Please feel free to try bumping up that version and creating a PR if it works

aurovrata commented 6 years ago

Shall try that

On 24 Mar 2018 12:24 a.m., "Benjamin Romano" notifications@github.com wrote:

The version of minimatch in this package is 2.0.10 which is now 3 years old. It's very possible that this functionality doesn't exist in this version.

Please feel free to try bumping up that version and creating a PR if it works

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benjaminRomano/todo-manager/issues/16#issuecomment-375766285, or mute the thread https://github.com/notifications/unsubscribe-auth/ACo28RsCcE6PwUxgpmSd_XSl_a57chivks5thUTUgaJpZM4S5HEP .