benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.
https://ui.nuxt.com
MIT License
53 stars 7 forks source link

feat(Tabs): handle `size` prop #124

Closed Silver343 closed 2 months ago

Silver343 commented 2 months ago

๐Ÿ”— Linked issue

Resolves #120

โ“ Type of change

๐Ÿ“š Description

Re-open #121 with new local branch

๐Ÿ“ Checklist

benjamincanac commented 2 months ago

Thank you!! ๐Ÿ˜Š

benjamincanac commented 2 months ago

Do you think we should apply the same logic everywhere for sizes? https://github.com/search?q=repo:benjamincanac/ui3+size%3D%22+path:/%5Esrc%5C/runtime%5C/components%5C//&type=code

Silver343 commented 2 months ago

I think it depends on if the parent component can be resized. The only child component that could be updated seems to be the Avatar component.

The size can still be overwritten by the user by passing it as part of the avatar object.