benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.
https://ui.nuxt.com
MIT License
53 stars 7 forks source link

feat(DropdownMenu): handle `color` prop #142

Closed Silver343 closed 1 month ago

Silver343 commented 1 month ago

๐Ÿ”— Linked issue

44

โ“ Type of change

๐Ÿ“š Description

Added a color prop with two options, white and `gray, customerised the theme baded on the color prop.

๐Ÿ“ Checklist

benjamincanac commented 1 month ago

@Silver343 I just made a major refactor of the components variant / color system: https://github.com/benjamincanac/ui3/pull/141 in which I remove all the white / black colors to only keep gray with multiple variants. I should have warned you but I didn't know I was gonna do this ๐Ÿ˜…

I guess we should apply the same concept for the DropdownMenu, ContextMenu, etc. Here is the Kbd now using a variant instead of a color: https://github.com/benjamincanac/ui3/pull/141/files#diff-97385f604c62eab3b9ee505e1ef570dcd2925d5624b3b6f7c3391162d2dffd40

We can brainstorm the name of the variant together if you want but I guess that would be outline (default) and subtle (the gray one) to be consistent.

Silver343 commented 1 month ago

@benjamincanac No worries, I'll update the pr, definitely makes sense to align the variant names.

Silver343 commented 1 month ago

Gonna close this PR and open a new one as this one as become very messy.