benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.
https://ui.nuxt.com
MIT License
52 stars 7 forks source link

feat(DropdownMenu): handle `variant` prop #144

Open Silver343 opened 4 months ago

Silver343 commented 4 months ago

๐Ÿ”— Linked issue

nuxt/ui#2146

โ“ Type of change

๐Ÿ“š Description

Cleaner version of nuxt/ui3#142.

๐Ÿ“ Checklist

benjamincanac commented 4 months ago

I'm not sure to understand why classes are not picked up for subtle variant ๐Ÿค”

Silver343 commented 4 months ago

@benjamincanac can you provide more details.

seems to be working for me.

image
benjamincanac commented 4 months ago

The divider should not be black (same in dark mode but white) and the hover states don't seem to work ๐Ÿ˜ฌ

Silver343 commented 4 months ago

it seems the current divider color is the browser default and the divide-gray-300 is not making it to the browser, this is the case if i change other components too. not sure how the tailwind jit works with the nuxt module and template file used.

Silver343 commented 4 months ago

it seems to be related to a dependency, when I switch to a outdated branch and install the dependancies then switch back it looks as expected and i can update it with new classes.

The hover isn't correct at the moment as the hover class and the bg class are the same color. Ive corrected for the screenshot below.

image

if I update the dependencies. it breaks as soon as i updated any class in the theme.

The last commit in the branch that works is e7e1b23