benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.

https://ui.nuxt.com

MIT License

53 stars 7 forks source link

feat(DropdownMenu): handle `variant` prop #144

Open Silver343 opened 1 month ago

Silver343 commented 1 month ago

🔗 Linked issue

44

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Cleaner version of #142.

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

benjamincanac commented 1 month ago

I'm not sure to understand why classes are not picked up for subtle variant 🤔

Silver343 commented 1 month ago

@benjamincanac can you provide more details.

seems to be working for me.

benjamincanac commented 1 month ago

The divider should not be black (same in dark mode but white) and the hover states don't seem to work 😬

Silver343 commented 1 month ago

it seems the current divider color is the browser default and the divide-gray-300 is not making it to the browser, this is the case if i change other components too. not sure how the tailwind jit works with the nuxt module and template file used.

Silver343 commented 1 month ago

it seems to be related to a dependency, when I switch to a outdated branch and install the dependancies then switch back it looks as expected and i can update it with new classes.

The hover isn't correct at the moment as the hover class and the bg class are the same color. Ive corrected for the screenshot below.

if I update the dependencies. it breaks as soon as i updated any class in the theme.

The last commit in the branch that works is e7e1b23