search

benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.
https://ui.nuxt.com
MIT License
52 stars 7 forks source link

[Drawer] Missing animation when closing programatically #54

Closed benjamincanac closed 6 months ago

benjamincanac commented 7 months ago

https://github.com/radix-vue/vaul-vue/issues/33

robin-dongbin commented 7 months ago

I think we should build this by ourself, based on radix-ui dialog

robin-dongbin commented 7 months ago

I saw we have a Slideover component already, what is diffrent with Drawer?

benjamincanac commented 7 months ago

The vaul-vue repository is part of Radix Vue, I don't see why we wouldn't use the available primitives, it works well 😊

robin-dongbin commented 7 months ago

I don't think we need this, I think we should rename Slideover to Drawer

Saeid-Za commented 7 months ago

Better to be based on a unified ecosystem! Although I tried to find a solution when I first encountered the issue, I'll try again.

robin-dongbin commented 7 months ago

Since I checked this component, it seems to be a parody IOS component built specifically for mobile, which is not the same as a component in a Drawer in most component libraries.

Instead, the Silderover component looks like a Drawer in most component libraries