benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.
https://ui.nuxt.com
MIT License
54 stars 8 forks source link

feat(Alert): new component #56

Closed robin-dongbin closed 5 months ago

robin-dongbin commented 5 months ago

๐Ÿ”— Linked issue

Resolves #23

โ“ Type of change

๐Ÿ“š Description

I had only contributed a few lines of code to open source projects before and had no experience with it, so I wanted to start with simple components and learn how to contribute.

Component logic and styles copy code from other components

This PR currently does not resolve the style variant issue. Colors and variants cannot be successfully applied and I don't know why.

I would really appreciate it if you could check it out and tell me how it can be improved.

๐Ÿ“ Checklist

benjamincanac commented 5 months ago

I'm so sorry I didn't see your PR, I just pushed the component ๐Ÿ˜…

robin-dongbin commented 5 months ago

No problem, I just want to accumulate experience, but I don't understand. I just checked your submission, which looks basically similar to my PR. Why can't my variant style take effect? What did I miss?

benjamincanac commented 5 months ago

What do you mean about variant style? I pushed the component before seing your PR. Feel free to open a new one to update the existing component ๐Ÿ˜Š