benjamincanac / ui3

A UI Library for Modern Web Apps, powered by Vue & Tailwind CSS.
https://ui.nuxt.com
MIT License
54 stars 8 forks source link

feat(Progress): new component #75

Closed sandros94 closed 4 months ago

sandros94 commented 4 months ago

Resolves #10

Implementation of the old UProgress component based on radix-vue's Progress one.

Currently done:

Notes

sandros94 commented 4 months ago

While working on the animations I've found an upstream issue, tracked here https://github.com/radix-vue/radix-vue/issues/910

sandros94 commented 4 months ago

marking as ready for review, although vitests are still missing

benjamincanac commented 4 months ago

@Sandros94 Do you plan to make the tests or do you want me to take care of it?

sandros94 commented 4 months ago

@Sandros94 Do you plan to make the tests or do you want me to take care of it?

Is it a problem if I ask you to take care of it? While it is a topic I would like to learn (I know little/nothing about vitests) I'm having some trouble finding the time for it, but I would also like to continue #52 and other components

benjamincanac commented 4 months ago

Not at all, I'll take care of it 😊

benjamincanac commented 4 months ago

@Sandros94 I've made a few changes alongside the tests, can you let me know if it's ok for you? 😊

sandros94 commented 4 months ago

@Sandros94 I've made a few changes alongside the tests, can you let me know if it's ok for you? 😊

Amazing ones! Thanks, this is also helping me notice where I should improve. In particular with: slots, vitest and tailwind-merge 😁