Closed sandros94 closed 4 months ago
While working on the animations I've found an upstream issue, tracked here https://github.com/radix-vue/radix-vue/issues/910
marking as ready for review, although vitests are still missing
@Sandros94 Do you plan to make the tests or do you want me to take care of it?
@Sandros94 Do you plan to make the tests or do you want me to take care of it?
Is it a problem if I ask you to take care of it? While it is a topic I would like to learn (I know little/nothing about vitests) I'm having some trouble finding the time for it, but I would also like to continue #52 and other components
Not at all, I'll take care of it 😊
@Sandros94 I've made a few changes alongside the tests, can you let me know if it's ok for you? 😊
@Sandros94 I've made a few changes alongside the tests, can you let me know if it's ok for you? 😊
Amazing ones! Thanks, this is also helping me notice where I should improve. In particular with: slots, vitest and tailwind-merge 😁
Resolves #10
Implementation of the old UProgress component based on radix-vue's Progress one.
Currently done:
Notes
elastic-vertical
animation doesn't respect themargin-top
.Indicator
. Since radix-vue already identifies the bar as the indicator.