feat(Modal): open programmatically

noook commented 6 months ago

🔗 Linked issue

Resolves #66

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allows opening modals dynamically

~One feature is missing: we cannot detect the end of the animation to reset the modal state, I think we need something upstream on radix-vue~

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

benjamincanac commented 6 months ago

We're no longer using a component to handle the transition but a CSS animation, I'm afraid it's not really related to radix-vue 🤔

noook commented 5 months ago

They use Presence which could kind of allow us to hook into the animation end (if there is one).

Submitted a PR (https://github.com/radix-vue/radix-vue/pull/901) on radix-vue so we can hook on it and reset state properly to avoid flickering while closing

noook commented 5 months ago

@benjamincanac It seems that the transition is now flawless, I didn't even update radix

I don't know what caused the issue last time I tried, but I remember the leaving animation was instant because the component was unmounted too early, it should be ready now

benjamincanac commented 5 months ago

Awesome! I've just renamed the modals plugin to modal and ModalsProvider component to ModalProvider for consistency.

benjamincanac commented 5 months ago

Thanks!!! 😊

benjamincanac / ui3