search

benjamindean / flutter_vibration

Handle vibration on iOS and Android in Flutter apps
217 stars 67 forks source link

1.7.4-nullsafety.0 vibration problems on ios #58

Closed nt4f04uNd closed 1 year ago

nt4f04uNd commented 3 years ago

during development of my app i pass qa on these devices and then on relese just bumped the version from 1.7.3 to 1.7.4-nullsafety.0

after app released i received a feedback that vibration is not working on these devices:

is it possible that there were any changes that might have broken the plugin for these?

benjamindean commented 3 years ago

Only on these devices? That's unlikely, but I'll check as soon as I can.

nt4f04uNd commented 3 years ago

these are only i recieved feedback about. if there's an issue with plugin, it's likely it affects more (or all) ios devices. i didn't see any logs in crashlytics, so i'm not sure. i personally have only iphone 7, so i can't really test this

benjamindean commented 3 years ago

I'm not sure what's going on here. nullsafety branch doesn't change much. Are you sure it works on older versions?

nt4f04uNd commented 3 years ago

no, i think i actually added one line of code, except of changing the version, that is before vibration i also called Vibration.cancel(). i think this was the problem, i am not sure if this was a bug, but looks weird

nt4f04uNd commented 3 years ago

just test if you can reproduce this - call awaited cancel and then vibrate, if there's no problem then close the issue

nt4f04uNd commented 3 years ago

by the way, what's might be happening here is https://github.com/benjamindean/flutter_vibration/issues/54 . i asked my qa team to retest

benjamindean commented 3 years ago

I don't have a physical iOS device to test on. So if you still have that problem - it's a bug.

nt4f04uNd commented 3 years ago

Sorry, I don't work on this project anymore so don't know about it. Anyways I suggest to check that per my comment https://github.com/benjamindean/flutter_vibration/issues/58#issuecomment-812854151

dark-chocolate commented 3 years ago

Make sure the vibration is turned on on both Android and iOS.

Android:

photo_2021-06-18 16 09 41

iOS:

photo_2021-06-18 16 09 44