Allow user to specify a maxLength for character diffing

benjamine / jsondiffpatch

Diff & patch JavaScript objects

MIT License

4.85k stars 472 forks source link

Allow user to specify a maxLength for character diffing #263

Open philnova opened 5 years ago

philnova commented 5 years ago

Users have reported inaccurate results from character diffing with very long strings, e.g. https://github.com/benjamine/jsondiffpatch/issues/248. This change would allow users to specify a max length for character diffing.

Methuselah96 commented 10 months ago

Thanks for the PR, and sorry for the delayed response! Do you have an example of "inaccurate results" with text diffing? It seems like the linked issue was primarily confused about text diffs in general which has now been disabled by default in v0.6.0.

Let us know if that satisfies the intent of this PR, or if there's anything else we can do to help.