benjamine / jsondiffpatch

Diff & patch JavaScript objects
MIT License
4.77k stars 464 forks source link

Temporarily remove prepublish #337

Closed Methuselah96 closed 1 year ago

Methuselah96 commented 1 year ago

npm lifecycle scripts are confusing.

prepack is supposed to be used for building for deployment. prepublish is supposed to be used for linting/testing.

However jsondiffpatch requires the package to be built before testing and there's no lifecycle script that runs after prepack to run tests.

So for now we'll just remove the prepublish script since testing and linting is already run in CI. Hopefully in the future we can run tests against the source files without needing to build first.