search

benjaminhoffman / gatsby-plugin-segment-js

Gatsby plugin for segment.com's analytic.js snippet
https://www.npmjs.com/package/gatsby-plugin-segment-js
MIT License
40 stars 28 forks source link

`includeTrackPage` is never referenced #14

Closed i8ramin closed 5 years ago

i8ramin commented 5 years ago

Looks like includeTrackPage is never used and should be included in the snippet

benjaminhoffman commented 5 years ago

good eye. oops. will fix

lsirivong commented 5 years ago

Hey @benjaminhoffman, anything I could do to help get this merged in?

benjaminhoffman commented 5 years ago

@i8ramin @lsirivong i've been slammed at work w stuff for the next two weeks. I would love to get this fixed sooner because it's clearly a bug. My apologies.

If you know a good fix, please open a PR and I'll merge! Sorry again for the bug.

lsirivong commented 5 years ago

No problem @benjaminhoffman, I totally get it! This actually is a PR that @i8ramin opened. I didn't test it myself but the change looks sensible to me: https://github.com/benjaminhoffman/gatsby-plugin-segment-js/pull/14/files