Rc 5 - Githubissues

newhouse commented 1 year ago

Trying to fix this: https://github.com/benjaminhoffman/gatsby-plugin-segment-js/issues/58

newhouse commented 1 year ago

@benjaminhoffman @eDubrovsky Do you have a few minutes to have a look at this? Especially the options that are available, and what it says that they do.

@eDubrovsky A few changes of note since the last beta you tried: delayLoadTime was changed to delayLoadDelay, and includeTitleInTrackPage is now defaulting to false.

newhouse commented 1 year ago

bump @benjaminhoffman @edubrovsky

newhouse commented 1 year ago

really wish there was a way to simplify all the page and load options... just feels like new devs will get bounce back and forth between which option is best and what happens when they include conflicting directions.

TBH, while I'm happy to contribute to this package and bring what I have to offer, I have to admit that I do not find myself super clear on the use-cases for some of the options, and I'm sure they could use better explantations...I've just reached my limit on that front with this library. Would you like to take a pass at updating the README to be more useful for Users? You probably know more about how this plugin is used than I do, I'm just doing my best to keep this thing modern, useful, feature-rich and bug-free.

did we / should we write tests for all the page options — like if they put both trackPageImmediately: true and trackPageOnlyIfReady: true... and other silly config like that?

I suppose it would be easy enough to validate the options in some manner that errors/warns when conflicting options have been provided.
Separate but related, "testing" out some of the functionality and behavior quirks would not really be possible without a more complex example site (probably not a big deal to enhance the existing one a little) combined with some sort of (headless) browser system to render the website in and watch the Network calls and/or the console logs. That's more than I'm willing to figure out at the moment, if I'm being honest.

benjaminhoffman commented 1 year ago

I've just reached my limit on that front with this library

me too! i don't blame you even for a sec. we're doing what we can and if others want to join in, happy to take the help. do what you can and what you prefer, I appreciate the maintenance! 🙏

benjaminhoffman / gatsby-plugin-segment-js

Rc 5 #59