search

benjaminjackman / looty

Looty! A tool for Path of Exile that makes inventory searching fun!
GNU General Public License v2.0
61 stars 21 forks source link

Some improvements #42

Closed piotrszymaniec closed 4 years ago

piotrszymaniec commented 4 years ago

Hey,

its few improvements, I have not upgraded version in manifest etc. Cherrypick commmits that you like :)

I don't know how to instantialize new js objects in scalajs. There are some plugins for slickgrid, like AutoColumnSize, that i'd like to try but to initialize plugin, I have to pass it like that (code from example in JS from plugin author )

grid.registerPlugin( new Slick.AutoColumnSize() )

And i have no clue how to make it from scala.

// some code from looty states :
grid = js.Dynamic.newInstance(global.Slick.Grid)("#grid", dataView, columns.getJsAy(), options)
//so i could probably...
grid.registerPlugin( <what-to-put-here?> )

Also I wish that I knew how to use PoeCacherChrome to store data between downtimes. Maps also could be read from there, as they are making pull request all over again.

Cheers

AnnanFay commented 4 years ago

I really like the idea of having an 'unparsed' column. It's a good failsafe since no matter how much work is done there will always be the potential for stuff which passes through the filters.

I have started using the above PR's branch and will post if I find any issues.

piotrszymaniec commented 4 years ago

oups hit wrong button ;)

piotrszymaniec commented 4 years ago

I really like the idea of having an 'unparsed' column. It's a good failsafe since no matter how much work is done there will always be the potential for stuff which passes through the filters.

I have started using the above PR's branch and will post if I find any issues.

Thank you!

I found that some of parsers are made for affixes, but never used in SelectColumns or anywhere else. So it was making unparsed column less useful.

I'll try to add it with your proposed chance to dodge etc.