search

benjaminjackman / looty

Looty! A tool for Path of Exile that makes inventory searching fun!
GNU General Public License v2.0
60 stars 21 forks source link

Attributes treated inconsistently #43

Closed AnnanFay closed 3 years ago

AnnanFay commented 4 years ago

The way the program treats the three primary stats is weird. Here is an example:

image

Looty lists this as giving +15% Evasion (IncreasedEvasion). Compare that to this:

image

Which shows up as 6.6% increased maximum energy shield (IncreasedMaxEnergyShield).

The second item integrates the effect of Intelligence into the global ES modifier (2% + 4.6%) while the first item does not integrate Dexterity. So, what happens when you have a piece of equipment with a local % modifier and an Intelligence bonus?

image

This item Looty will show as having: 24% increased evasion and 7% increased ES.

So increased ES will always be global increased ES including intelligence. Increased Evasion will either be local increase, or it will be global increase ignoring dexterity.

I'm not sure what the best way to fix this is but it would be nice if there was a consistent treatment of local and global modifiers. There's currently no way of retrieving a local ES modifier, or seeing the full global evasion modifier on an item.

piotrszymaniec commented 3 years ago

I've fixed this issue in my local repo - which I hope I'll put into PR soon. I'd like to make it before next league.

I have added:

benjaminjackman commented 3 years ago

ok sounds good to me, thanks, when is the next league?

On Tue, Jan 12, 2021 at 05:41 Traf notifications@github.com wrote:

I've fixed this issue in my local repo - which I hope I'll put into PR soon. I'd like to make it before next league.

I have added:

  • local Energy Shield %
  • local Armour %
  • local Evasion Rating % Changed:
  • Evasion Rating to global, and included dexterity, more so I have converted each item with dex, to show global Evasion Rating

  • % increased Armour to global one

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/benjaminjackman/looty/issues/43#issuecomment-758600640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPEYGG7FJ64VMXM2PHLBLSZQYNJANCNFSM4LRFRTZQ .

piotrszymaniec commented 3 years ago

15th friday ;)