Closed LooperzZ closed 10 months ago
I agree with LooperzZ. It will make it easier to try out the code. Furthermore, there will be coherence with the description provided. Thanks for the effort to share.
Hello, thank you for bringing attention to this topic. I have updated the README file. We made some changes and inadvertently forgot to update the README file.
Benjamin, thanks for your quick response.
The problem with
Indoor: ./scripts/reproduce_test/indoor.sh Outdoor: ./scripts/reproduce_test/outdoor.sh
is that they activate a virtual environment called loftr, but the one created here
conda env create -f environment.yaml conda activate samnet
is samnet.
We will have a problem to run indoor.sh and outdoor.sh
What do you think?
Joaquin
On Fri, Jan 12, 2024 at 11:30 AM Benjamin @.***> wrote:
Hello, thank you for bringing attention to this topic. I have updated the README file. We made some changes and inadvertently forgot to update the README file.
— Reply to this email directly, view it on GitHub https://github.com/benjaminkelenyi/SAM-Net/issues/1#issuecomment-1889693112, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU4SASQHTV6G5M5G4WWBTYOFXKLAVCNFSM6AAAAABBUHWNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGY4TGMJRGI . You are receiving this because you commented.Message ID: @.***>
--
Joaquin Salas
Issue fixed! You were right; I resolved the problem. Instead of recreating the environment, simply update the correct environment name in the script files.
Thanks, Benjamin. I appreciate your help.
But what about pixloc? The folder is empty and it is called by test.py
Thanks!
On Fri, Jan 12, 2024 at 1:19 PM Benjamin @.***> wrote:
Issue fixed! You were right; I resolved the problem. Instead of recreating the environment, simply update the correct environment name in the script files.
— Reply to this email directly, view it on GitHub https://github.com/benjaminkelenyi/SAM-Net/issues/1#issuecomment-1889826789, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU4SC7F22PBHZ4SHAJSTDYOGEEPAVCNFSM6AAAAABBUHWNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZHAZDMNZYHE . You are receiving this because you commented.Message ID: @.***>
--
Joaquin Salas
Thanks, Benjamin. I appreciate your help. But what about pixloc? The folder is empty and it is called by test.py Thanks! … On Fri, Jan 12, 2024 at 1:19 PM Benjamin @.> wrote: Issue fixed! You were right; I resolved the problem. Instead of recreating the environment, simply update the correct environment name in the script files. — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLU4SC7F22PBHZ4SHAJSTDYOGEEPAVCNFSM6AAAAABBUHWNDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZHAZDMNZYHE . You are receiving this because you commented.Message ID: @.>
------------------------ Joaquin Salas
Please check: https://github.com/benjaminkelenyi/SAM-Net/issues/2
Hello author, the demo folder and demo.py written in your profile are not provided, I don't know how to call your code, can you provide a sample, thank you very much!