search

benjaminkott / bootstrap_package

Bootstrap Package delivers a full configured theme for TYPO3, based on the Bootstrap CSS Framework.
https://www.bootstrap-package.com/
MIT License
338 stars 206 forks source link

Gallery pagination not working in news detail view #1185

Open buepro opened 2 years ago

buepro commented 2 years ago

Bug Report

Prerequisites

Description

When using a gallery content element in a news record the pagination doesn't work.

Steps to Reproduce

  1. Add gallery content element with four images showing two images per page.
  2. Show the detail view from the news with the gallery element
  3. Click the link to show page 2 from the gallery

Expected behavior

The user should be able to navigate through the gallery pages.

Actual behavior

The news url parameters are not respected.

Versions

b13/container                              1.6.1    Create Custom Container Content Elements for TYPO3
bacon/bacon-qr-code                        2.0.7    BaconQrCode is a QR code generator for PHP.
bk2k/bootstrap-package                     12.0.5   Bootstrap Package delivers a full configured frontend theme for TYPO3, based on the Bootstrap CSS Framework.
buepro/typo3-container-elements            v3.1.1   TYPO3 extension providing content elements powered by container and bootstrap. Available elements: container, columns, tabs, accordion, tile unit, card and randomizer.
buepro/typo3-easyconf                      dev-main Provides a module to easily configure main aspects from a website.
buepro/typo3-pvh                           v1.1.1   A collection of view helpers used by pizpalue. Contains copies from vhs view helpers by Claus Due.
christian-riesen/base32                    1.6.0    Base32 encoder/decoder according to RFC 4648
composer/pcre                              3.0.0    PCRE wrapping library that offers type-safe preg_* replacements.
composer/semver                            3.3.2    Semver library that offers utilities, version constraint parsing and validation.
composer/xdebug-handler                    3.0.3    Restarts a process without Xdebug.
dasprid/enum                               1.0.3    PHP 7.1 enum implementation
doctrine/annotations                       1.13.3   Docblock Annotations Parser
doctrine/cache                             2.2.0    PHP Doctrine Cache library is a popular cache implementation that supports many different drivers such as redis, memcache, apc, mongodb and others.
doctrine/dbal                              2.13.9   Powerful PHP database abstraction layer (DBAL) with many features for database schema introspection and management.
doctrine/deprecations                      v1.0.0   A small layer on top of trigger_error(E_USER_DEPRECATED) or PSR-3 logging with options to disable all deprecations or selectively for packages.
doctrine/event-manager                     1.1.1    The Doctrine Event Manager is a simple PHP event system that was built to be used with the various Doctrine projects.
doctrine/instantiator                      1.4.1    A small, lightweight utility to instantiate objects in PHP without invoking their constructors
doctrine/lexer                             1.2.3    PHP Doctrine Lexer parser library that can be used in Top-Down, Recursive Descent Parsers.
egulias/email-validator                    3.2.1    A library for validating emails against several RFCs
enshrined/svg-sanitize                     0.15.4   An SVG sanitizer for PHP
ergebnis/composer-normalize                2.28.3   Provides a composer plugin for normalizing composer.json.
ergebnis/json-normalizer                   2.1.0    Provides generic and vendor-specific normalizers for normalizing JSON documents.
ergebnis/json-printer                      3.2.0    Provides a JSON printer, allowing for flexible indentation.
ergebnis/json-schema-validator             2.0.0    Provides a JSON schema validator, building on top of justinrainbow/json-schema.
friendsofphp/php-cs-fixer                  v3.9.4   A tool to automatically fix PHP code style
friendsoftypo3/phpstan-typo3               0.8.1    TYPO3 rules for PHPStan
friendsoftypo3/tt-address                  6.1.0    Displays a list of addresses from an address table on the page.
georgringer/eventnews                      5.0.0    Extend EXT:news with event and calendar functionality
georgringer/news                           9.4.0    Versatile news system based on Extbase & Fluid and using the latest technologies provided by TYPO3 CMS.
guzzlehttp/guzzle                          7.4.5    Guzzle is a PHP HTTP client library
guzzlehttp/promises                        1.5.1    Guzzle promises library
guzzlehttp/psr7                            2.4.0    PSR-7 message implementation that also provides common utility methods
helhum/config-loader                       v0.12.5  Generic config loader with context and environment support.
helhum/typo3-console                       v7.1.2   A reliable and powerful command line interface for TYPO3 CMS
justinrainbow/json-schema                  5.2.12   A library to validate a json schema.
localheinz/diff                            1.1.1    Fork of sebastian/diff for use with ergebnis/composer-normalize
lolli42/finediff                           1.0.2    PHP implementation of a Fine granularity Diff engine
masterminds/html5                          2.7.5    An HTML5 parser and serializer.
mikey179/vfsstream                         v1.6.10  Virtual file system to mock the real file system in unit tests.
myclabs/deep-copy                          1.11.0   Create deep copies (clones) of your objects
n98/junit-xml                              1.1.0    JUnit XML Document generation library
nikic/php-parser                           v4.14.0  A PHP parser written in PHP
overtrue/phplint                           2.4.1    `phplint` is a tool that can speed up linting of php files by running several lint processes at once.
phar-io/manifest                           2.0.3    Component for reading phar.io manifest information from a PHP Archive (PHAR)
phar-io/version                            3.2.1    Library for handling version information and constraints
php-cs-fixer/diff                          v2.0.2   sebastian/diff v3 backport support for PHP 5.6+
phpdocumentor/reflection-common            2.2.0    Common reflection classes used by phpdocumentor to reflect the code structure
phpdocumentor/reflection-docblock          5.3.0    With this component, a library can provide support for annotations via DocBlocks or otherwise retrieve information that is embedded in a DocBlock.
phpdocumentor/type-resolver                1.6.1    A PSR-5 based resolver of Class names, Types and Structural Element Names
phpspec/prophecy                           v1.15.0  Highly opinionated mocking framework for PHP 5.3+
phpspec/prophecy-phpunit                   v2.0.1   Integrating the Prophecy mocking library in PHPUnit test cases
phpstan/phpstan                            0.12.99  PHPStan - PHP Static Analysis Tool
phpstan/phpstan-deprecation-rules          0.12.6   PHPStan rules for detecting usage of deprecated classes, methods, properties, constants and traits.
phpstan/phpstan-phpunit                    0.12.22  PHPUnit extensions and rules for PHPStan
phpstan/phpstan-strict-rules               0.12.11  Extra strict and opinionated rules for PHPStan
phpunit/php-code-coverage                  9.2.15   Library that provides collection, processing, and rendering functionality for PHP code coverage information.
phpunit/php-file-iterator                  3.0.6    FilterIterator implementation that filters files based on a list of suffixes.
phpunit/php-invoker                        3.1.1    Invoke callables with a timeout
phpunit/php-text-template                  2.0.4    Simple template engine.
phpunit/php-timer                          5.0.3    Utility class for timing
phpunit/phpunit                            9.5.21   The PHP Unit Testing framework.
psr/cache                                  1.0.1    Common interface for caching libraries
psr/container                              1.1.2    Common Container Interface (PHP FIG PSR-11)
psr/event-dispatcher                       1.0.0    Standard interfaces for event handling.
psr/http-client                            1.0.1    Common interface for HTTP clients
psr/http-factory                           1.0.1    Common interfaces for PSR-7 HTTP message factories
psr/http-message                           1.0.1    Common interface for HTTP messages
psr/http-server-handler                    1.0.1    Common interface for HTTP server-side request handler
psr/http-server-middleware                 1.0.1    Common interface for HTTP server-side middleware
psr/log                                    1.1.4    Common interface for logging libraries
]8;;uphie/getallheaders                    3.0.3    A polyfill for getallheaders.
    scssphp/scssphp                            v1.10.3  scssphp is a compiler for SCSS written in PHP.
sebastian/cli-parser                       1.0.1    Library for parsing CLI options
sebastian/code-unit                        1.0.8    Collection of value objects that represent the PHP code units
sebastian/code-unit-reverse-lookup         2.0.3    Looks up which function or method a line of code belongs to
sebastian/comparator                       4.0.6    Provides the functionality to compare PHP values for equality
sebastian/complexity                       2.0.2    Library for calculating the complexity of PHP code units
sebastian/diff                             4.0.4    Diff implementation
sebastian/environment                      5.1.4    Provides functionality to handle HHVM/PHP environments
sebastian/exporter                         4.0.4    Provides the functionality to export PHP variables for visualization
sebastian/global-state                     5.0.5    Snapshotting of global state
sebastian/lines-of-code                    1.0.3    Library for counting the lines of code in PHP source code
sebastian/object-enumerator                4.0.4    Traverses array structures and object graphs to enumerate all referenced objects
sebastian/object-reflector                 2.0.4    Allows reflection of object attributes, including inherited and non-public ones
sebastian/recursion-context                4.0.4    Provides functionality to recursively process PHP variables
sebastian/resource-operations              3.0.3    Provides a list of PHP built-in functions that operate on resources
sebastian/type                             3.0.0    Collection of value objects that represent the types of the PHP type system
sebastian/version                          3.0.2    Library that helps with managing the version number of Git-hosted PHP projects
symfony/cache                              v5.4.10  Provides an extended PSR-6, PSR-16 (and tags) implementation
symfony/cache-contracts                    v2.5.2   Generic abstractions related to caching
symfony/config                             v5.4.9   Helps you find, load, combine, autofill and validate configuration values of any kind
symfony/console                            v5.4.10  Eases the creation of beautiful and testable command line interfaces
symfony/dependency-injection               v5.4.10  Allows you to standardize and centralize the way objects are constructed in your application
symfony/deprecation-contracts              v2.5.2   A generic function and convention to trigger deprecation notices
symfony/event-dispatcher                   v5.4.9   Provides tools that allow your application components to communicate with each other by dispatching events and listening to them
symfony/event-dispatcher-contracts         v2.5.2   Generic abstractions related to dispatching event
symfony/expression-language                v5.4.10  Provides an engine that can compile and evaluate expressions
symfony/filesystem                         v5.4.9   Provides basic utilities for the filesystem
symfony/finder                             v5.4.8   Finds files and directories via an intuitive fluent interface
symfony/http-foundation                    v5.4.10  Defines an object-oriented layer for the HTTP specification
symfony/lock                               v5.4.10  Creates and manages locks, a mechanism to provide exclusive access to a shared resource
symfony/mailer                             v5.4.10  Helps sending emails
symfony/mime                               v5.4.10  Allows manipulating MIME messages
symfony/options-resolver                   v5.4.3   Provides an improved replacement for the array_replace PHP function
symfony/polyfill-ctype                     v1.26.0  Symfony polyfill for ctype functions
symfony/polyfill-intl-grapheme             v1.26.0  Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-icu                  v1.26.0  Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn                  v1.26.0  Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer           v1.26.0  Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring                  v1.26.0  Symfony polyfill for the Mbstring extension
symfony/polyfill-php72                     v1.26.0  Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73                     v1.26.0  Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/polyfill-php80                     v1.26.0  Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions
symfony/polyfill-php81                     v1.26.0  Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions
symfony/process                            v5.4.8   Executes commands in sub-processes
symfony/property-access                    v5.4.8   Provides functions to read and write from/to an object or array using a simple string notation
symfony/property-info                      v5.4.10  Extracts information about PHP class' properties using metadata of popular sources
symfony/rate-limiter                       v5.4.9   Provides a Token Bucket implementation to rate limit input and output in your application
symfony/routing                            v5.4.8   Maps an HTTP request to a set of configuration variables
symfony/service-contracts                  v2.5.2   Generic abstractions related to writing services
symfony/stopwatch                          v5.4.5   Provides a way to profile code
symfony/string                             v5.4.10  Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way
symfony/var-exporter                       v5.4.10  Allows exporting any serializable PHP data structure to plain PHP code
symfony/yaml                               v5.4.10  Loads and dumps YAML files
theseer/tokenizer                          1.2.1    A small library for converting tokenized PHP source code into XML and potentially other formats
typo3/class-alias-loader                   v1.1.3   Amends the composer class loader to support class aliases to provide backwards compatibility for packages
typo3/cms-backend                          v11.5.13 Classes for the TYPO3 backend.
typo3/cms-base-distribution                v11.5.1  TYPO3 CMS Base Distribution
typo3/cms-belog                            v11.5.13 Displays backend log, both per page and system wide. Available as the module Tools>Log (system wide overview) and Web>Info/Log (page relative overview).
typo3/cms-beuser                           v11.5.13 Backend user administration and overview. Allows you to compare the settings of users and verify their permissions and see who is online.
typo3/cms-cli                              3.1.0    TYPO3 command line binary
typo3/cms-composer-installers              v3.1.2   TYPO3 CMS Installers
typo3/cms-core                             v11.5.13 The core library of TYPO3.
typo3/cms-dashboard                        v11.5.13 Dashboard for TYPO3.
typo3/cms-extbase                          v11.5.13 A framework to build extensions for TYPO3 CMS.
typo3/cms-extensionmanager                 v11.5.13 TYPO3 Extension Manager
]8;;3/cms-felogin                          v11.5.13 A template-based plugin to log in Website Users in the Frontend
    typo3/cms-filelist                         v11.5.13 Listing of files in the directory
typo3/cms-fluid                            v11.5.13 Fluid is a next-generation templating engine which makes the life of extension authors a lot easier!
typo3/cms-fluid-styled-content             v11.5.13 A set of common content elements based on Fluid for Frontend output.
typo3/cms-form                             v11.5.13 Form Library, Plugin and Editor
typo3/cms-frontend                         v11.5.13 Classes for the frontend of TYPO3.
typo3/cms-impexp                           v11.5.13 Import and Export of records from TYPO3 in a custom serialized format (.T3D) for data exchange with other TYPO3 systems.
typo3/cms-info                             v11.5.13 Shows various infos
typo3/cms-install                          v11.5.13 The Install Tool mounted as the module Tools>Install in TYPO3.
typo3/cms-lowlevel                         v11.5.13 Enables the 'Config' and 'DB Check' modules for technical analysis of the system. This includes raw database search, checking relations, counting pages and records etc.
typo3/cms-recordlist                       v11.5.13 List of database-records
typo3/cms-recycler                         v11.5.13 The recycler offers the possibility to restore deleted records or remove them from the database permanently. These actions can be applied to a single record, multiple records, and recursively to child records ...  
typo3/cms-rte-ckeditor                     v11.5.13 Integration of CKEditor as Rich Text Editor.
typo3/cms-seo                              v11.5.13 SEO features for TYPO3.
typo3/cms-setup                            v11.5.13 Allows users to edit a limited set of options for their user profile, eg. preferred language and their name and email address.
typo3/cms-sys-note                         v11.5.13 Records with messages which can be placed on any page and contain instructions or other information related to a page or section.
typo3/cms-t3editor                         v11.5.13 JavaScript-driven editor with syntax highlighting and code completion. Based on CodeMirror.
typo3/cms-tstemplate                       v11.5.13 Framework for management of TypoScript template records for the CMS frontend.
typo3/cms-viewpage                         v11.5.13 Shows the frontend webpage inside the backend frameset.
typo3/html-sanitizer                       v2.0.14  HTML sanitizer aiming to provide XSS-safe markup based on explicitly allowed tags, attributes and values.
typo3/phar-stream-wrapper                  v3.1.7   Interceptors for PHP's native phar:// stream handling
typo3/symfony-psr-event-dispatcher-adapter v2.1.0   Adapter to provide compatibility with the Symfony's event dispatcher interface in all versions with the PSR-14 specification.
typo3/testing-framework                    6.16.5   The TYPO3 testing framework provides base classes for unit, functional and acceptance testing.
typo3fluid/fluid                           2.7.1    The TYPO3 Fluid template rendering engine
webmozart/assert                           1.11.0   Assertions to validate method input/output with nice error messages.
fishbone1 commented 1 year ago

Why are there so many problems with the pull request although there are just a few changes that should work on all PHP versions? Should we just provide a new pull request?

georgringer commented 1 year ago

Why are there so many problems with the pull request although there are just a few changes that should work on all PHP versions? Should we just provide a new pull request?

yes I would propose an updated PR should make it work