benjaminkott / bootstrap_package

Bootstrap Package delivers a full configured theme for TYPO3, based on the Bootstrap CSS Framework.

https://www.bootstrap-package.com/

MIT License

338 stars 205 forks source link

[BUGFIX] Remove outdated language settings causing empty links #1494

Closed linawolf closed 1 month ago

linawolf commented 4 months ago

Since TYPO3 9.5 language settings are handled by the site config.

The linkVars setting causes hard to find bugs where all links on a page are empty, see:

https://forge.typo3.org/issues/104344 https://talk.typo3.org/t/empty-href-on-arbitary-pages/5737

Resolves: https://github.com/benjaminkott/bootstrap_package/issues/1165

Pull Request

Related Issues

Closes #
Fixes # [bug]
Resolves # [feature/question]

Prerequisites

[ ] Changes have been tested on TYPO3 v11.5 LTS
[ x] Changes have been tested on TYPO3 v12.4 LTS
[ ] Changes have been tested on PHP 7.4
[ ] Changes have been tested on PHP 8.0
[ ] Changes have been tested on PHP 8.1
[x ] Changes have been tested on PHP 8.2
[ x] Changes have been checked for CGL compliance php-cs-fixer fix
[ ] CSS has been rebuilt (only if there are SCSS changes cd Build; npm ci; npm run build)

Description

[Description of changes proposed in this pull request]

Steps to Validate

See Issue

linawolf commented 4 months ago

phpstan errors are unrelated and have been broken since before