search

benjaminkott / bootstrap_package

Bootstrap Package delivers a full configured theme for TYPO3, based on the Bootstrap CSS Framework.
https://www.bootstrap-package.com/
MIT License
338 stars 206 forks source link

Wrong icon size after changing the constants #756

Open web2date opened 5 years ago

web2date commented 5 years ago

Bug Report

The icon in a medium size content element texticon don't resize to a larger value if the constant is changed from default to 60. plugin.bootstrap_package_contentelements.texticon.icon.medium.height = 60 plugin.bootstrap_package_contentelements.texticon.icon.medium.width = 60

Prerequisites

Description

If for example the constant plugin.bootstrap_package_contentelements.texticon.icon.medium.height and plugin.bootstrap_package_contentelements.texticon.icon.medium.width is changed to 60 the icon doesnt appear bigger in the frontend even if the img size is 60x60. It stays small (48x48px).

Steps to Reproduce

  1. Change plugin.bootstrap_package_contentelements.texticon.icon.medium.height and plugin.bootstrap_package_contentelements.texticon.icon.medium.width to 60
  2. Check the frontend
  3. The icon size is 60x60 but the box is still 48x48

Expected behavior: texticon-size-3

Actual behavior: texticon-size-1 texticon-size-2

Versions

TYPO3 9.5.9 - Bootstrap Package 11.0.1

gilbertsoft commented 5 years ago

Seems to be related to your PR #743

gilbertsoft commented 5 years ago

@benjaminkott I had a deeper look at this issue. Imho we should remove this options if you don't have a solution for it. The sizes can be changed by override the scss template in a sitepackage which should not harm anything and is imho a clean solution. The scss defines multiple sizes for each view port and here we provide just a single value, this must be conflicting somehow!