benjaminkott / packagebuilder

Sitepackage-Builder is your kickstarter for modern TYPO3 Theme development.
https://www.sitepackagebuilder.com
MIT License
30 stars 12 forks source link

no version defined #38

Open sunfish opened 4 years ago

sunfish commented 4 years ago

Hi Benjamin, to install sitepackage with composer i have added to my composer.json "repositories": [ {"type": "artifact", "url": "localRepository/"} ], "require": { "vendor/name": "^1" } From https://sitepackagebuilder.com/ created sitepackage "name.zip" has been copied in my local directory "localRepository". composer update get's an error alert: [UnexpectedValueException] Package / has no version defined. I have added in the composer.json in the zip file: "version": "1" After I put the changed composer.json back into the zip archive, the sitepackage was successfully installed with composer update.

From my point of view it would make sense if the version information of the sitepackagebuilder would not only be entered in ext_emconf.php but also in composer.json to allow a smooth installation with composer.

Thanks a lot
Ulrich

gilbertsoft commented 4 years ago

Hi @sunfish

The correct way of using a sitepackage from a local path repository looks like this:

composer config repositories.local path "'packages/*'"
composer require "my-company/my-sitepackage:@dev"

See the @dev version constraint which is the recommended one for packages from local path repos.

Using the version in a composer.json is not recommended at all because Composer uses the information from the tags / branches.