benjaminor / kkp

Emacs support for the Kitty Keyboard Protocol
GNU General Public License v3.0
32 stars 6 forks source link

Don't concatenate the ?u and ?~ lists when retrieving the keycode representation #5

Closed dnkl closed 1 year ago

dnkl commented 1 year ago

The two lists are not disjunct. For example '13' maps to <return> in the ?u list, and <f3> in the ?~ list.

This fixes an actual issue, where F3 is incorrectly mapped to <return> in terminal emulators implementing the latest version of the kkp specification, where the legacy sequence for F3 is no longer allowed (due to it conflicting with cursor position reports).

This is perhaps not the most pretty solution, but at least highlights the problem :)

benjaminor commented 1 year ago

Thanks for catching this!