benjaminpope / drpangloss

the best of all possible interferometry models
https://benjaminpope.github.io/drpangloss/
MIT License
2 stars 0 forks source link

new interface #11

Closed benjaminpope closed 4 months ago

benjaminpope commented 4 months ago

Tested and demonstrated minimal version of all existing functions in new object-oriented API. Functions that have been superseded have been moved to models_old.py.

There are now plotting scripts in plotting.py that do the plots formatted à la Dori. One thing to do is to fix the plotting code to have some nice way of showing the percentile/sigma level automatically (perhaps via object-oriented grids & plotting?) - see Issue #10.

This still only has interfaces for BinaryModelCartesian and not BinaryModelAngular, which I would like to have.

I am concerned about a mismatch between the Absil method as implemented in the new and old versions (Issue #9).

In future, I want to move the likelihood and optimization related code out of models.py into their own thing, and models.py should exclusively have things like BinaryModel.