benjaminpope / drpangloss

the best of all possible interferometry models
https://benjaminpope.github.io/drpangloss/
MIT License
2 stars 0 forks source link

Fixed ra dec switch bug, added tests for consistency across all likelihood grids #18

Closed shashankdholakia closed 4 months ago

shashankdholakia commented 4 months ago

In optimized_likelihood_grid, optimized_contrast_grid and others, the RA and Dec were switched, which evaded notice because the simulated binary separations were the same in RA and Dec. This fixes that issue, and changes the notebooks oidata_sandbox and upper_limits_new with the fixes.

In addition, I've updated all the grid codes to return an array of shape (dra, ddec) and the plotting codes to take the same and handle the transposing internally.