search

benjaminpope / drpangloss

the best of all possible interferometry models
https://benjaminpope.github.io/drpangloss/
MIT License
2 stars 0 forks source link

replace `onp, np` with `np, jnp` #21

Open benjaminpope opened 4 months ago

benjaminpope commented 4 months ago

@shashankdholakia has strong feelings that we should replace onp, np with np, jnp. I tend to agree. Opening this issue in case @LouisDesdoigts has strong feelings otherwise.

LouisDesdoigts commented 4 months ago

I tend to prefer the former, since I never really use normal numpy at all. From what I have seen of most jax code-bases import as np, unless there is large parts of the code that use normal numpy.

I would say we should probably just use whatever convention the other jax packages in the ecosystem near us use, but ultimately its preference.